buffer messages before writing to file#13
Open
But2ene wants to merge 4 commits intooptimizers:masterfrom
Open
Conversation
Add two properties to the logging class bufferMessages : The first is a cell array that contains messages to be written. bufferCursor_ is an integer that points to next cell to write in bufferMessages_ During logging, messages are added to buffer. Once it's full, log lines are written on file. This new feature have no impact on logging on console. A new method called setBufferingSize was created to change buffer size, on the model of the others methods
Author
|
Hello, I hope you find the style of code respected in this commit, and you find it usefull. |
Member
|
Thank you. Could you show in what circumstances this improves performance? I expect Matlab to already implement some sort of buffering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two properties to the logging class
bufferMessages : The first is a cell array that contains messages to be
written.
bufferCursor_ is an integer that points to next cell to write in
bufferMessages_
During logging, messages are added to buffer. Once it's full, log lines
are written on file.
This new feature have no impact on logging on console.
A new method called setBufferingSize was created to change buffer size, on the model of the
others methods